fix having inapropriate ammo in CL lockbox. #4071
Conversation
as in is lock box but can't use with the gun he as in is safe. adding the possibility to buy extra ammo as CL
github-actions
bot
added
Balance
as i mentioned in my bug report: the CL no longer spawns with the 88 Mod4 in their safe, instead spawning with the ES-4 electrostatic pistol, despite this the CL still receives a lockbox full of 88Mod4 rubber and AP ammo, when I asked a mentor where the CL could find a 88 mod4 to use this ammo, they responded that i should ask a marine to vend me one from a marine prep room, based on this I assume it's an oversight for the CL to have ammo for a weapon they aren't issued, and that they'd have to ask others to acquire said weapon. The new sidearm the CL is issued only gets 3 magazines and it seems like there is no other place to find more, this PR not only solves the confusing question of "why would WY issue a nonlethal weapon to the CL, yet give them lethal ammo for a weapon they aren't issued", but also helps to solve the problem of ES-4 ammo being extremely rare. |
No, i'm looking for justification for nuking the lockbox ammo entirely, as this PR does |
i removed /obj/item/storage/lockbox/loyalty/fill_preset_inventory() thinking it would work without it. |
This still fails to address the issue I raised of a pack of justification. |
? i am confused i am not removing the lock-box just the ammo in it because it's obsolete considering the new gun CL as. |
actually. fair point, having an empty lockbox seems a bit silly. |
Zonespace27
added
Balance
About the pull request
fixes: #3976
Explain why it's good for the game
removing the improper ammo in the lock box because it's obsolete considering the new gun CL as.
adding a way to buy more ammo so that CL as a way to refill is weapon.
didn't wanted to give it for free in the lockbox.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
balance: adding the possibility to buy "ES-4 stun magazine" for 10 point in the portable vendor.
fix: remove a bunch of ammo that where improper for ES-4 gun that are in the lockbox.
/:cl: